forked from Zulko/moviepy
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles support #1
Open
vsquareg
wants to merge
58
commits into
master
Choose a base branch
from
subtitles_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct variable name in progress bar The progress bar is using "t" to represent what is actually a frame index, making it confusing for people implementing custom progress bars. This is not retro-compatible for people who have already implemented a custom progress bar since the "t" was introduced, so it would be for a v2.0.
* Fix black version in Code Format Check workflow of CI * Update black version in pre-commit configuration
…otebook in Windows (Zulko#1537) * Update preview.py, fix issue Zulko#575 Fixed issue Zulko#575. Added two pg.quit statements at lines 146 and 162. For line 146, this statement adds quit functionality for " event.type == pg.KEYDOWN and event.key == pg.K_ESCAPE". This allows the window to close whenever the event triggers. For line 162, once the for loop ends (the video ends), the window closes instead of crashing. Co-authored-by: jacobwhiteman17 <54951159+jacobwhiteman17@users.noreply.github.com>
* Bug fix: for rotating mask images. * Formatted code with black
* Update CodeQL analysis fetch-checkout logic in CI * Add missing CHANGELOG entry for previous pull request
* Test mask rotation
…#1544) * Add tests for rotate FX when Pillow is not installed * Improve comment * Add pragma: no cover on ImportError statement
* Add test for supported 'rotate' kwargs by PIL version
…ulko#1552) * VideoClip blitting: fix truncation bug to enable fractional opacity This fixes Zulko#1369 for me, which was broken as of fe5c782 due to a `truncate before multiply' bug. * Added unit test for composition with opacity * Refactored blit result unit test for reuse * Fix linting problems * Add CHANGELOG entry
* Bump decorator to <6.0 * Update code instrospection logic in decorators
* On autorotate flip the video_size - ffmpeg autorotates videos but the video_size is unhanged, this results e.g. in stretched output images or even unreadable images or videos. This commit exchanges width and height if 90 or 270 degree rotation was detected. * Use fix directly in video writer, add test cases * Remove uneeded files * Add CHANGELOG entry Co-authored-by: Florian Zierer <florian.zierer@moticon.de> Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
* Add tests for 'audio_fadein' FX Refactored audio_fadein to improve performance. Fix mono clips crashing when audio_fadein FX applied. Add support to pass duration parameter as time format (AA:BB:CC, tuples...). Document it properly.
* Add tests for 'audio_fadeout' FX * Fix linting issue * Add CHANGELOG entry
…ness' value (Zulko#1546) * Document 'accel_decel' FX properly * Improve docstring * Add CHANGELOG entry * Update image * Update image * Make 'f_accel_decel' a private function * Update image * Clarify examples paragraph * Two spaces of indentation in docstring
…#1579) * Test left, right, top, bottom and color arguments of margin FX * Format properly margin FX docstring * Test margin FX using ColorClip
…ko#1572) * Add 'start' and 'end' parameters to multiply_volume FX * Add CHANGELOG entry * Add test for videoclip volume transformation * Remove dead code * Allow to pass seconds to 'start' and 'end' arguments in seconds format * Refactor function call * Use clip.end instead of clip.duration in FX * Make 'start' and 'end' arguments more explicit
* Document 'find_video_period' and reformat test * Simplify example
* Add tests for 'slide_in' transition
* Test editor preview methods * Don't install optional requirements for Python3.7 tests under Linux in CI
* Test utilities, refactor increasing tests performance
* Add tests for 'find_audio_period' * Refactor wave creations in tests
* Test some ffmpeg video tools and document them * Fix test error in Windows
* Add tests for Clip class and improve its documentation * Minor improvements * Add CHANGELOG entry
* Add tests for videoclip and root __init__ * Fix error in docstring * Parametrize frames in 'save_frame' test * Change matplotlib backend in tests to 'Agg' * Change all 'matplotlib' imports by 'matplotlib.pyplot' in tests * Add tuple format t parameter in save_frame test
* Add tests for HTML tools
* Refactor tests files * Increase subtitles clip test performance
* Delete redundant on_color.py * Update CHANGELOG.md
…#1594) * Allow to pass 't' argument of 'clip.show' as 'HH:MM:SS' format * Add CHANGELOG entry
* Add tests for 'download_webfile'
* Update CI configuration * Remove appveyor file * Remove appveyor badge from README
* Add tests for config
* Add tests and documentation for FramesMatches * Allow to pass optional arguments to clip.write_gif using FramesMatches.write_gifs
* Scroll fix
* Add tests for ffmpeg_write_image * Add tests for ffmpeg_write_video function
* Add support for 'loop' argument writing GIFs with ffmpeg * Add CHANGELOG entry
* Add tests and documentation for interpolators
* Add tests for 'find_objects' video tool
* Document tracking functions parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/