Haveibeenpwnd review #148
Merged
Haveibeenpwnd review #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added remote call to API - configurable parameters: timeout, mandatory check, behaviour on timeouts - Allow different endpoints - Returns the number of found occurrences as `CountCategory.Pwnd` - Adds `-Duser.language=en` to ensure working tests on non-english development platforms fixes #146
General reanme of HaveIveBeenPwnd to HaveIBeenPwned to match naming from the service. Provide separate connect and read timeout properties. Rename mandatory to allowExposed for clarity. Rename allowPasswordDuringTimeout to allowOnException since its implementation isn't limited solely to timeouts. Use cryptacular for hashing and encoding. Modify test class to extend AbstractRuleTest. Use wiremock for unit tests to avoid external dependencies.
serac
requested changes
Aug 30, 2023
Co-authored-by: Marvin S. Addison <marvin.addison+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.