Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new list-context.product-list interface #229

Merged
merged 28 commits into from
Feb 6, 2020

Conversation

victorhmp
Copy link
Contributor

What is the purpose of this pull request?

Add a new interface list-content.product-list interface that uses list-context to create a list of products that should be used along with a slider-layout to create a Shelf of products.

What problem is this solving?

It enables us to compose a Shelf from smaller blocks instead of using the current one.

How should this be manually tested?

Workspace

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@victorhmp victorhmp self-assigned this Jan 31, 2020
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 31, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@victorhmp victorhmp changed the title Create new list-content.product-list interface Create new list-context.product-list interface Feb 2, 2020
@victorhmp victorhmp marked this pull request as ready for review February 3, 2020 19:22
@victorhmp victorhmp requested review from a team and steckhelena February 3, 2020 19:22
react/ProductSummaryList.js Outdated Show resolved Hide resolved
react/ProductSummaryList.js Outdated Show resolved Hide resolved
react/ProductSummaryList.js Outdated Show resolved Hide resolved
react/components/ProductSummary.js Show resolved Hide resolved
docs/ProductSummaryList.md Outdated Show resolved Hide resolved
victorhmp and others added 2 commits February 5, 2020 19:00
Co-Authored-By: Rafael Klynger <rafael.dantas@vtex.com.br>
@victorhmp victorhmp merged commit fdf8354 into master Feb 6, 2020
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 6, 2020

Your PR has been merged! App is being published. 🚀
Version 2.50.2 → 2.51.0

After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-summary@2.51.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@victorhmp victorhmp deleted the feature/product-summary-list branch February 6, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants