Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Carousel and Shelf in favor of list components #190

Merged
merged 13 commits into from
Feb 6, 2020

Conversation

victorhmp
Copy link
Contributor

@victorhmp victorhmp commented Jan 9, 2020

What problem is this solving?

Our base Store Theme did not contain any examples on the use of slider-layout and was still using vtex.carousel in the home page. That would encourage users to keep using the carousel instead of using our composable solution of list-contex.image-list + slider-layout.

The same problem applies to the shelf block, which is now a list-context.product-list + slider-layout.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

Notes

This depends on vtex-apps/product-summary#229

@victorhmp victorhmp self-assigned this Jan 9, 2020
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 9, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 9, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

CHANGELOG.md Outdated Show resolved Hide resolved
@victorhmp victorhmp requested a review from klzns January 9, 2020 13:46
Copy link
Contributor

@Klynger Klynger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add to the carousel and the shelf this logic, because the shelf is a total different use case of the slider-layout, so if something pops up, its easier to change the slider-layout

@victorhmp victorhmp force-pushed the feature/slider-layout-and-image-list branch 2 times, most recently from 2173a52 to 62f1199 Compare February 3, 2020 19:45
@victorhmp victorhmp changed the title Remove Carousel and custom minicart.v2 implementation Remove Carousel and Shelf in favor of list components Feb 3, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@victorhmp victorhmp force-pushed the feature/slider-layout-and-image-list branch from d333608 to 517e81b Compare February 6, 2020 19:32
@victorhmp victorhmp merged commit 12c121b into master Feb 6, 2020
@victorhmp victorhmp deleted the feature/slider-layout-and-image-list branch February 6, 2020 19:35
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 6, 2020

Your PR has been merged! App is being published. 🚀
Version 3.24.0 → 3.25.0

After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-theme@3.25.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants