-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Carousel and Shelf in favor of list components #190
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to add to the carousel and the shelf this logic, because the shelf is a total different use case of the slider-layout, so if something pops up, its easier to change the slider-layout
2173a52
to
62f1199
Compare
Co-Authored-By: Breno Calazans <breno@vtex.com.br>
Co-Authored-By: Iaron da Costa Araújo <iaron.araujo@vtex.com.br>
d333608
to
517e81b
Compare
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-notifications) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Our base Store Theme did not contain any examples on the use of
slider-layout
and was still usingvtex.carousel
in the home page. That would encourage users to keep using the carousel instead of using our composable solution oflist-contex.image-list
+slider-layout
.The same problem applies to the
shelf
block, which is now alist-context.product-list
+slider-layout
.How should this be manually tested?
Workspace
Checklist/Reminders
README.md
.CHANGELOG.md
.Type of changes
Notes
This depends on vtex-apps/product-summary#229