This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
feat(ui): create postal code bar component #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for basestore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-424--base.preview.vtex.app |
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here Errors It looks like you were trying to add the config file? Please rename "gatsby-config.ts" to "gatsby-config.js" |
…o fss-232-create-postal-code-bar
saranicoly
requested review from
sergiofontes,
hellofanny,
eduardoformiga,
filipewl and
renatamottam
filipewl
approved these changes
Apr 8, 2022
|
Hey @saranicoly, to solve the Cummulative Layout Shift (CLS) on Lighthouse CI we need to get the changes after #472 was merged. |
ArthurTriis1
approved these changes
Apr 12, 2022
Conflicts: - src/styles/global/components.scss
* Removes `RegionalizationProvider` * Moves `RegionalizationProvider` logic to `ModalProvider` * Separates `RegionalizationComponents` into different folders and files to keep project structure * Uses specific states for each modal
when opening/closing `RegionalizationModal`
saranicoly
force-pushed
the
fss-232-create-postal-code-bar
branch
from
31ced5a
to
9890463
Compare
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to create a "postal code bar" like this:
Since the behavior varies depending on the device, we have two different components:
RegionalizationButton(Desktop) andRegionalizationBar(mobile).How does it work?
The initial state of the components is as shown above, but if the user sets a location, the current location must be shown instead of "Set your location" message:
This is made using a
contentprop:classesprop informs if the component will be shown on mobile (in case of RegionalizationBar) or desktop (in case of RegionalizationButton).Mobile:
Desktop:
How to test it?
You have a few options to do that.
Option 1: Deploy Preview
Option 2: Running locally
Extra:
contentprop.References
Checklist