This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
fix: Hero layout shift #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-472--base.preview.vtex.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
filipewl
approved these changes
Apr 11, 2022
eduardoformiga
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Great! 👏
I was trying to investigate this CLS on another PR. Good to know that the flex order is affecting it :)
This was referenced Apr 11, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
We were having issues with this component on the PLP when removing the PostalCodeInput component. This can be seen in here: https://github.com/vtex-sites/storeframework.store/pull/46
This issue was fixed after we did the changes described on this PR in here: https://github.com/vtex-sites/storeframework.store/pull/46/commits/6efa3ccfb9f794be2bd44bc219ef3b7606876177
Having that said, I propose merging this fix in here so we don't have to deal with it in the future.
How does it work?
This PR inverts the rendering order to match the render on mobile. This fixes CLS. To avoid rendering the incorrect order, the
flexdisplay was also inverted. This fixed the Layout Shift regions on lighthouse report.How to test it?
Make sure nothing changed and that the layout shift was fixed in: https://github.com/vtex-sites/storeframework.store/pull/46
Checklist