generated from vtex-sites/base.store
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve integration tests by upgrading Cypress to 9.5.4 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 6.6.0. This way it matches [Cypress version run by WebOps that was recently updated][1]. [1]: https://github.com/vtex/vtex-cicd-platform/pull/182
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-e583194--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit e583194
|
Considering these are simple changes and that they have been approved via vtex-sites/nextjs.store#177, I'm going to go ahead and merge this. Do let me know if you find any issues! |
filipewl
pushed a commit
that referenced
this pull request
Jul 22, 2022
## What's the purpose of this pull request? From 9.5.4. This way, it matches [Cypress version run by WebOps that was recently updated][1]. [1]: https://github.com/vtex/vtex-cicd-platform/pull/217 ## How to test it? Run `yarn develop` and then `yarn test`. ## References Similar to #148.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
From 6.6.0. This way, it matches Cypress version run by WebOps that was recently updated.
How to test it?
Run
yarn develop
and thenyarn test
.