Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Uses OutOfStock component from FSUI #70

Merged
merged 5 commits into from
May 30, 2022

Conversation

ArthurTriis1
Copy link
Contributor

Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com

This PR will replicate the changes made in this gatsby.store #34.

What's the purpose of this pull request?

This PR is part of the Component Placement project. Using OutOfStock

How does it work?

  • Uses OutOfStock component from FSUI

How to test it?

  • Nothing should change visually on the component.
PDP

Screen Shot 2022-05-27 at 11 27 44

Checklist

You may erase this after checking them all ;)

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview May 30, 2022 at 0:56AM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented May 27, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-af39cef--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit af39cef

@vtex-sites
Copy link

vtex-sites bot commented May 27, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit af39cef

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse-99988212/p
📎   /office

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
src/components/product/OutOfStock/OutOfStock.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should we simulate an error state in Storybook as well?

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@ArthurTriis1 ArthurTriis1 merged commit 88c1e46 into main May 30, 2022
@ArthurTriis1 ArthurTriis1 deleted the feat/FSSS-249-Add-OutOfStock branch May 30, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants