Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update pull_request_template.md checklist #4

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

Mariana-Caetano
Copy link

@Mariana-Caetano Mariana-Caetano commented Apr 27, 2022

What's the purpose of this pull request?

Added new items to the pull_request_template.md to help highlight the changes added in the CHANGELOG.md and Release Notes.

This is analogous to the #12 PR in gatsby.store.

How does it work?

The new items intended to help users and the team identify the changes in gatsby.store and keep a pattern in the CHANGELOG.md update.

Checklist Item Before Now
CHANGELOG entry added
Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
Added the PR number with the PR link at the entry in the CHANGELOG.md
Updated the Storybook - if applicable.
Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.
For documentation changes, ping @ carolinamenezes or @ Mariana-Caetano to review and update the changes.

How to test it?

Describe the steps with bullet points. Is there any external reference, link, or example?

References

Checklist

You may erase this after checking them all ;)

  • CHANGELOG entry added

@Mariana-Caetano Mariana-Caetano added the Documentation Improvements or additions to documentation label Apr 27, 2022
@vtex-sites
Copy link

vtex-sites bot commented Apr 27, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://preview-4--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 167d06a

@vtex-sites
Copy link

vtex-sites bot commented Apr 27, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

Page Report
/ 📎   Access the Lighthouse report here.
/apple-magic-mouse-99988212/p 📎   Access the Lighthouse report here.
/office 📎   Access the Lighthouse report here.

@Mariana-Caetano Mariana-Caetano marked this pull request as ready for review April 27, 2022 16:51
@Mariana-Caetano Mariana-Caetano changed the title Doc: Update PR template checklist Doc: Update pull_request_template.md checklist Apr 27, 2022
@tlgimenes tlgimenes mentioned this pull request Jul 7, 2022
This was referenced Jul 7, 2022
@tlgimenes tlgimenes mentioned this pull request Jul 7, 2022
8 tasks
@victorhmp victorhmp mentioned this pull request Jul 11, 2022
8 tasks
@lucasfp13 lucasfp13 mentioned this pull request Jul 12, 2022
6 tasks
@tlgimenes tlgimenes mentioned this pull request Jul 13, 2022
8 tasks
@tlgimenes tlgimenes mentioned this pull request Jul 14, 2022
8 tasks
@renatamottam renatamottam mentioned this pull request Jul 18, 2022
7 tasks
@nicacioliveira nicacioliveira mentioned this pull request Jul 19, 2022
8 tasks
@lucasfp13 lucasfp13 mentioned this pull request Jul 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants