refactor: Import Tiles & Tile components from @faststore/ui
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
filipewl
force-pushed
the
chore/fs-360-tiles-from-starter
branch
from
50ae988
to
1ff3efc
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-185--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit fa8b4f1
|
filipewl
commented
Jul 29, 2022
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "@faststore/api": "^1.10.19", | |||
| "@faststore/graphql-utils": "^1.10.6", | |||
| "@faststore/sdk": "^1.10.6", | |||
| "@faststore/ui": "^1.10.7", | |||
| "@faststore/ui": "https://pkg.csb.dev/vtex/faststore/commit/94943c32/@faststore/ui", | |||
There was a problem hiding this comment.
🎗️Reminder to update this before the merge.
ArthurTriis1
approved these changes
Aug 1, 2022
filipewl
added a commit
to vtex/faststore
that referenced
this pull request
Aug 1, 2022
## What's the purpose of this pull request? Extract the `Tiles` and `Tile` component from the [starters](https://github.com/vtex-sites/nextjs.store/tree/81b2cbcae8157703130ab18356178cb15c8bcf12/src/components/ui/Tiles) and move it to the `@faststore/ui` package. ## How to test it? Run `yarn storybook` locally and check the [`Tiles` component page](http://localhost:6006/?path=/docs/organisms-tiles--tiles). Its Storybook page:  The same component being used on the starter:  ### Starters Deploy Preview - vtex-sites/nextjs.store#185 and the [deploy preview](https://preview-185--nextjs.preview.vtex.app/)
hellofanny
approved these changes
Aug 2, 2022
emersonlaurentino
approved these changes
Aug 2, 2022
Conflicts: - package.json - yarn.lock
filipewl
changed the title
Tiles & Tile components from @faststore/uiTiles & Tile components from @faststore/ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Extract the
TilesandTilecomponent from the starters and move it to the@faststore/uipackage.How to test it?
The
TilesandTilecomponents are used in the "Just Arrived" section on the Home page. There should be no visual difference between before and after these changes.References
Tiles&Tilecomponents from the starter vtex/faststore#1421