-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Import Tiles
& Tile
components from @faststore/ui
#185
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
50ae988
to
1ff3efc
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-185--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit fa8b4f1
|
package.json
Outdated
@@ -33,7 +33,7 @@ | |||
"@faststore/api": "^1.10.19", | |||
"@faststore/graphql-utils": "^1.10.6", | |||
"@faststore/sdk": "^1.10.6", | |||
"@faststore/ui": "^1.10.7", | |||
"@faststore/ui": "https://pkg.csb.dev/vtex/faststore/commit/94943c32/@faststore/ui", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎗️Reminder to update this before the merge.
## What's the purpose of this pull request? Extract the `Tiles` and `Tile` component from the [starters](https://github.com/vtex-sites/nextjs.store/tree/81b2cbcae8157703130ab18356178cb15c8bcf12/src/components/ui/Tiles) and move it to the `@faststore/ui` package. ## How to test it? Run `yarn storybook` locally and check the [`Tiles` component page](http://localhost:6006/?path=/docs/organisms-tiles--tiles). Its Storybook page: ![CleanShot 2022-07-29 at 15 26 25](https://user-images.githubusercontent.com/381395/181822535-577ec95e-0076-4191-ab20-d4a64386e9d4.png) The same component being used on the starter: ![CleanShot 2022-07-29 at 15 41 38](https://user-images.githubusercontent.com/381395/181824154-5f0a8e64-7520-470a-b26a-452c0f837149.png) ### Starters Deploy Preview - vtex-sites/nextjs.store#185 and the [deploy preview](https://preview-185--nextjs.preview.vtex.app/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceeee! Approving cause it's looking the same as before 👍
Conflicts: - package.json - yarn.lock
Tiles
& Tile
components from @faststore/ui
Tiles
& Tile
components from @faststore/ui
What's the purpose of this pull request?
Extract the
Tiles
andTile
component from the starters and move it to the@faststore/ui
package.How to test it?
The
Tiles
andTile
components are used in the "Just Arrived" section on the Home page. There should be no visual difference between before and after these changes.References
Tiles
&Tile
components from the starter vtex/faststore#1421