Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter active brands #1157

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix: filter active brands #1157

merged 1 commit into from
Feb 22, 2022

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Feb 22, 2022

What's the purpose of this pull request?

This PR fixes the error below:

ERROR

NotFoundError: Catalog returned FullText for slug: canyon. This usually happens when there is more than one category with the same name in the same category tree level.
    at /Users/gimenes/Documents/code/vtex-sites/base.store/node_modules/@faststore/api/src/platforms/vtex/loaders/collection.ts:38:17
    at processTicksAndRejections (node:internal/process/task_queues:93:5) {
  locations: [ { line: 32, column: 3 } ],
  path: [ 'allCollections', 'edges', 9, 'node', 'breadcrumbList' ]
}

How it works?

We were receiving this error because the list of brands the api returns contains inactive brands. A simple filter solved the issue.

base.store Deploy Preview

vtex-sites/base.store#361

@tlgimenes tlgimenes requested a review from a team as a code owner February 22, 2022 19:18
@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for faststoreui ready!

🔨 Explore the source changes: 7a38121

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/62153702bfe9cc000884d33b

😎 Browse the preview: https://deploy-preview-1157--faststoreui.netlify.app

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for faststore-docs ready!

🔨 Explore the source changes: 7a38121

🔍 Inspect the deploy log: https://app.netlify.com/sites/faststore-docs/deploys/6215370287a90c00071262c5

😎 Browse the preview: https://deploy-preview-1157--faststore-docs.netlify.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a38121:

Sandbox Source
Store UI Typescript Configuration

@tlgimenes tlgimenes merged commit 5821683 into master Feb 22, 2022
@tlgimenes tlgimenes deleted the feat/filter-brand branch February 22, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants