Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: using tsc instead tsdx on build script #1362

Merged
merged 8 commits into from
Jun 17, 2022
Merged

chore: using tsc instead tsdx on build script #1362

merged 8 commits into from
Jun 17, 2022

Conversation

emersonlaurentino
Copy link
Member

@emersonlaurentino emersonlaurentino commented Jun 14, 2022 •
edited
Loading

What's the purpose of this pull request?

We want to remove tsdx completely, so this pr initializes this process starting on script build.

How it works?

The build script was changed to use tsc lib instead tsdx.

How to test it?

Running the command

yarn build

Starters Deploy Preview

References

@emersonlaurentino emersonlaurentino requested a review from a team as a code owner June 14, 2022 17:23
@emersonlaurentino emersonlaurentino self-assigned this Jun 14, 2022
@vercel
Copy link

vercel bot commented Jun 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 6:09PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12fe9c1:

Sandbox Source
Store UI Typescript Configuration

@emersonlaurentino
Copy link
Member Author

After the script was changed, the other script size stopped working. I think we need to upgrade the size-limit dependency to the newer major (4 -> 7).

Screen Shot 2022-06-14 at 14 27 20

@emersonlaurentino emersonlaurentino changed the base branch from main to feat/lint June 17, 2022 15:42
@emersonlaurentino emersonlaurentino changed the title chore: using tsc instead tsdx on ui build chore: using tsc instead tsdx on build script Jun 17, 2022
filipewl
filipewl approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
CleanShot 2022-06-17 at 14 01 25

eduardoformiga
eduardoformiga approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/lint to main June 17, 2022 17:52
@emersonlaurentino emersonlaurentino merged commit 16c41bb into main Jun 17, 2022
@emersonlaurentino emersonlaurentino deleted the chore/remove-tsdx branch June 17, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipewl filipewl filipewl approved these changes

@tlgimenes tlgimenes tlgimenes approved these changes

@eduardoformiga eduardoformiga eduardoformiga approved these changes

Assignees

@emersonlaurentino emersonlaurentino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emersonlaurentino @filipewl @tlgimenes @eduardoformiga