Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom label, help, hint and errors block #493

Merged
merged 10 commits into from
Sep 26, 2018
Merged

Custom label, help, hint and errors block #493

merged 10 commits into from
Sep 26, 2018

Conversation

lionel-bijaoui
Copy link
Member

@lionel-bijaoui lionel-bijaoui commented Sep 24, 2018 •
edited

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    New feature
  • What is the new behavior (if this is a feature change)?
    Label, help, hint, and errors template can be changed with slot (respectively label, help, hint, and errors)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

    • Possibility to use scoped-slot to customise fully how label, help, hint and errors are build
    • Little change to the structure to make it easy to do this
    • Heavy use of scoped-slot
    • Work with groups
    • Expose field object and getValueFromOption function. For errors, errors object is also exposed.

Lionel Bijaoui added 4 commits September 24, 2018 10:59
Custom label, help and hint
a7a1bd3 
- Possibility to use scoped-slot to customise fully how label, help or hint are build
- Little change to the structure to make it easy to do this
- Heavy use of scoped-slot
- Expose `field` object and `getValueFromOption` function
Custom errors
12434e3 
- Possibility to use scoped-slot to customise fully how errors are build
- Expose `errors` object, `field` object and `getValueFromOption` function
Make custom label, help, hint and errors work with groups
94be402 
- Create a new dev project to test custom and project
- Remove custom code from "full" dev project
Enhance "custom" dev project with better examples
05a1e8e 
- Label with icon depending on field input type
- Help with support for Markdown
- Errors displayed in a table
- Hint with icon and color
@coveralls
Copy link

coveralls commented Sep 24, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 87.524% when pulling 301ab94 on lionel-bijaoui:lb_custom_label_help_&_hint into 02055ec on vue-generators:v3.

@lionel-bijaoui lionel-bijaoui requested review from zoul0813 and a team September 24, 2018 09:41
@lionel-bijaoui lionel-bijaoui mentioned this pull request Sep 24, 2018
Open
@lionel-bijaoui lionel-bijaoui merged commit b02d866 into vue-generators:v3 Sep 26, 2018
@lionel-bijaoui lionel-bijaoui deleted the lb_custom_label_help_&_hint branch September 26, 2018 07:28
@lionel-bijaoui lionel-bijaoui added this to Done in v3.0 Oct 5, 2018
@muschottkey
Copy link

@lionel-bijaoui @zoul0813
Thanks for the work you've done so far on vfg 👏 👏

I was wondering, when will v3 be released?

It seems to have quite important features (like this MR) already that would be great to have instead of trying to find work-arounds.

@zoul0813
Copy link
Member

zoul0813 commented Jun 4, 2019

No ETA as of yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoul0813 zoul0813 Awaiting requested review from zoul0813

Assignees
No one assigned
Labels
None yet
Projects
v3.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lionel-bijaoui @coveralls @muschottkey @zoul0813