-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle visibility + Quaternion Support #439
Conversation
# Conflicts: # src/core/vgl-object3d.js # src/parsers.js # src/three.js # src/validators.js
Mh. Not sure about these failing checks. Any ideas? |
Thank you very much for your creating PR ! |
Ok, I have fixed the linting errors. Please tell me if further changes are required. Thank you! |
Well, I'm wondering about The quaternion will overwrite the rotation configuration at initializing. That should be documented in the prop comment. (Comment will appear in published documentation page.) And, could you modify the test case? What you need to do is just adding new propsData and assertions to test/core/vgl-object3d.spec.js . Thank you :-) |
I have added the tests and comments. It does not make much sense to use rotation and rotationQuaternion in at the same time, so I stated this in the documentation. Technically yes, rotationQuaternion overrides rotation in the initialization, however if you dynamically change the props at some point, the behavior would be reaaally confusing and weird if you used both at the same time. As for the name of the prop: To be honest, I feel like the original property in Three.js is not well-named. 'quaternion' is a similar term as 'matrix' or 'vector. And you wouldn't call a some specific vector or rotation matrix just 'vector' or 'matrix' in a property, would you? Therefore I feel like rotationQuaternion is clearer. If you prefer the original name for consistency, I can also change it back. Whatever you prefer. |
Thank you for good explanation about naming. Actually, I couldn't catch the nuance since I usually don't use English. I agree to clearer naming. |
I have added: