Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(better-define): cannot import type from vue file #210

Merged
merged 9 commits into from
Jan 14, 2023
Merged

fix(better-define): cannot import type from vue file #210

merged 9 commits into from
Jan 14, 2023

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Jan 14, 2023

Description

Extract setupScript content if they import type from vue file.

Linked Issues

closes #208

Additional context

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2023

🦋 Changeset detected

Latest commit: 9a01540

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@vue-macros/api Patch
@vue-macros/better-define Patch
@vue-macros/common Patch
@vue-macros/define-model Patch
unplugin-vue-macros Patch
unplugin-vue-define-options Patch
@vue-macros/define-props Patch
@vue-macros/define-render Patch
@vue-macros/define-slots Patch
@vue-macros/hoist-static Patch
@vue-macros/named-template Patch
@vue-macros/reactivity-transform-vue2 Patch
@vue-macros/setup-block Patch
@vue-macros/setup-component Patch
@vue-macros/setup-sfc Patch
@vue-macros/short-emits Patch
@vue-macros/short-vmodel Patch
@vue-macros/volar Patch
@vue-macros/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stackblitz
Copy link

stackblitz bot commented Jan 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel vercel bot temporarily deployed to Preview January 14, 2023 10:53 Inactive
@vercel vercel bot temporarily deployed to Preview January 14, 2023 10:56 Inactive
@vercel vercel bot temporarily deployed to Preview January 14, 2023 11:06 Inactive
@alexzhang1030 alexzhang1030 changed the title fix: cannot use better-define import from vue file fix: cannot import type from vue file Jan 14, 2023
packages/common/src/vue.ts Outdated Show resolved Hide resolved
packages/common/src/vue.ts Outdated Show resolved Hide resolved
packages/common/src/vue.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 14, 2023 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview January 14, 2023 14:41 Inactive
@alexzhang1030
Copy link
Member Author

Perhaps need improve docs , tell users what type of typing defininitions can handle.

packages/common/src/vue.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 14, 2023 15:56 Inactive
packages/common/src/vue.ts Outdated Show resolved Hide resolved
@sxzz sxzz changed the title fix: cannot import type from vue file fix(better-define): cannot import type from vue file Jan 14, 2023
@vercel vercel bot temporarily deployed to Preview January 14, 2023 19:35 Inactive
@sxzz sxzz enabled auto-merge (squash) January 14, 2023 19:36
@vercel vercel bot temporarily deployed to Preview January 14, 2023 19:36 Inactive
@sxzz sxzz merged commit a673932 into vue-macros:main Jan 14, 2023
@github-actions github-actions bot mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import from vue file (Nuxt)
2 participants