Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-inbrowser-compiler-demi@4.44.21 issue #1295

Closed
cthinkzz opened this issue Mar 18, 2022 · 9 comments
Closed

vue-inbrowser-compiler-demi@4.44.21 issue #1295

cthinkzz opened this issue Mar 18, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@cthinkzz
Copy link

Current behavior

Hi I am working in one of the React Project, It seems like vue-inbrowser-compiler-demi has been updated recently. So I am getting below error whenever I try to do npm install
image

node version: 12.16.1
npm version: 6.13.4

Any suggestions to fix this issue would be very helpful.
Thanks in advance.
To reproduce

Expected behavior

@elevatebart
Copy link
Member

Are you working with a monorepo?

@elevatebart
Copy link
Member

If you install vue-styleguidist or vue live, you are normally responsible for installing vue.

This is vue-Demi telling you it cannot find vue nor detect its version.

I should make this error more meaningful.

Can you try and share a repo where I could reproduce this error? If not, best advice is add vue to the dev dependencies of the project where you run styleguidist.

@elevatebart
Copy link
Member

One thing that could be done here is to wrap this require in a try-catch like in vue-Demi.

This way we could make this "error" silent and still have most of vue-styleguidist working.

I am surprised by the path where the compiler-Demi is installed. I must be missing an important detail.

If you take the time to open a PR I'd be delighted.

Thank you for reporting anyway.

@kfw9257
Copy link

kfw9257 commented Mar 18, 2022

I'm also seeing a similar error with an Angular project that is a part of a monorepo.

image

Node version 14.13.0
NPM version 7.24.0

@kfw9257
Copy link

kfw9257 commented Mar 18, 2022

Update: I was able to fix my issue by removing all storybook js dependencies from my package.json. I'm not using storybook in my app currently so it wasn't a big issue.

@elevatebart elevatebart added the bug Something isn't working label Mar 18, 2022
@elevatebart elevatebart added this to todo in vue-styleguidist via automation Mar 18, 2022
@cthinkzz
Copy link
Author

Update: I was able to fix my issue by removing all storybook js dependencies from my package.json. I'm not using storybook in my app currently so it wasn't a big issue.

Thanks for the input but I am using storybook in my project. So I can't really remove any storybook dependencies.
As @elevatebart suggested, I added vue as devDependency and it worked fine.

@cthinkzz
Copy link
Author

cthinkzz commented Mar 18, 2022

If you install vue-styleguidist or vue live, you are normally responsible for installing vue.

This is vue-Demi telling you it cannot find vue nor detect its version.

I should make this error more meaningful.

Can you try and share a repo where I could reproduce this error? If not, best advice is add vue to the dev dependencies of the project where you run styleguidist.

Thanks for the response. I am not using styleguidlist/vue-live. But I assume any one of my dependencies might be using these packages, but it worked fine when I added vue as devDependency.
One observation is project was working fine until it got latest release today for https://www.npmjs.com/package/vue-inbrowser-compiler
image

@elevatebart
Copy link
Member

can you do npm ls vue-inbrowser-compiler and post the result here?
This will help me know why you have a vue specific package installed in an Angular project.

version 4.44.22 should not need the installation of vue anymore.

@cthinkzz
Copy link
Author

can you do npm ls vue-inbrowser-compiler and post the result here? This will help me know why you have a vue specific package installed in an Angular project.

version 4.44.22 should not need the installation of vue anymore.

Thanks for the quick response. Yeah it's working fine now without 'vue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants