perf: update some attrs

vueComponent · Jan 18, 2020 · 8b6b506 · 8b6b506
1 parent 3cb68f5
commit 8b6b506
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 8 deletions.
diff --git a/components/_util/proxyComponent.jsx b/components/_util/proxyComponent.jsx
@@ -23,7 +23,7 @@ export default function wrapWithConnect(WrappedComponent) {
       },
     },
     render() {
-      const { $listeners, $slots = {}, $attrs, $scopedSlots } = this;
+      const { $listeners, $slots = {}, $scopedSlots } = this;
       const props = getOptionProps(this);
       const wrapProps = {
         props: {
@@ -33,7 +33,6 @@ export default function wrapWithConnect(WrappedComponent) {
           children: $slots.default || props.children || [],
         },
         on: $listeners,
-        attrs: $attrs,
       };
       if (Object.keys($scopedSlots).length) {
         wrapProps.scopedSlots = $scopedSlots;

diff --git a/components/_util/store/connect.jsx b/components/_util/store/connect.jsx
@@ -81,7 +81,7 @@ export default function connect(mapStateToProps) {
       },
       render() {
         this.preProps = { ...this.$props };
-        const { $listeners, $slots = {}, $attrs, $scopedSlots, subscribed, store } = this;
+        const { $listeners, $slots = {}, $scopedSlots, subscribed, store } = this;
         const props = getOptionProps(this);
         this.preProps = { ...omit(props, ['__propsSymbol__']) };
         const wrapProps = {
@@ -91,7 +91,6 @@ export default function connect(mapStateToProps) {
             store,
           },
           on: $listeners,
-          attrs: $attrs,
           scopedSlots: $scopedSlots,
         };
         return (

diff --git a/components/grid/Col.jsx b/components/grid/Col.jsx
@@ -46,7 +46,6 @@ export default {
       pull,
       prefixCls: customizePrefixCls,
       $slots,
-      $attrs,
       $listeners,
       rowContext,
     } = this;
@@ -82,7 +81,6 @@ export default {
     };
     const divProps = {
       on: $listeners,
-      attrs: $attrs,
       class: classes,
       style: {},
     };

diff --git a/components/input/Password.jsx b/components/input/Password.jsx
@@ -14,6 +14,7 @@ const ActionMap = {
 export default {
   name: 'AInputPassword',
   mixins: [BaseMixin],
+  inheritAttrs: false,
   model: {
     prop: 'value',
     event: 'change.value',

diff --git a/components/input/TextArea.jsx b/components/input/TextArea.jsx
@@ -30,6 +30,7 @@ function noop() {}
 
 export default {
   name: 'ATextarea',
+  inheritAttrs: false,
   model: {
     prop: 'value',
     event: 'change.value',

diff --git a/components/input/__tests__/__snapshots__/demo.test.js.snap b/components/input/__tests__/__snapshots__/demo.test.js.snap
@@ -62,6 +62,6 @@ exports[`renders ./components/input/demo/size.md correctly 1`] = `<div class="co
 
 exports[`renders ./components/input/demo/textarea.md correctly 1`] = `<textarea placeholder="Basic usage" rows="4" class="ant-input"></textarea>`;
 
-exports[`renders ./components/input/demo/textarea-resize.md correctly 1`] = `<div><button type="button" class="ant-btn" style="margin-bottom: 16px;"><span>Auto Resize: {String(autoResize)}</span></button> <textarea rows="4" class="ant-input"></textarea></div>`;
+exports[`renders ./components/input/demo/textarea-resize.md correctly 1`] = `<div><button type="button" class="ant-btn" style="margin-bottom: 16px;"><span>Auto Resize: false</span></button> <textarea rows="4" class="ant-input"></textarea></div>`;
 
 exports[`renders ./components/input/demo/tooltip.md correctly 1`] = `<input placeholder="Input a number" type="text" maxlength="25" class="ant-input" style="width: 120px;">`;
diff --git a/components/input/demo/textarea-resize.md b/components/input/demo/textarea-resize.md
@@ -12,7 +12,7 @@ For multi-line input.
 <template>
   <div>
     <a-button style="margin-bottom: 16px" @click="() => this.autoResize = !autoResize">
-      Auto Resize: {String(autoResize)}
+      Auto Resize: {{String(autoResize)}}
     </a-button>
     <a-textarea :rows="4" :autosize="autoResize" :defaultValue="defaultValue" />
   </div>

diff --git a/components/modal/Modal.jsx b/components/modal/Modal.jsx
@@ -75,6 +75,7 @@ export const destroyFns = [];
 
 export default {
   name: 'AModal',
+  inheritAttrs: false,
   model: {
     prop: 'visible',
     event: 'change',
@@ -161,6 +162,7 @@ export default {
       centered,
       $listeners,
       $slots,
+      $attrs,
     } = this;
 
     const getPrefixCls = this.configProvider.getPrefixCls;
@@ -197,6 +199,7 @@ export default {
       },
       class: getClass(this),
       style: getStyle(this),
+      attrs: $attrs,
     };
     return <Dialog {...dialogProps}>{$slots.default}</Dialog>;
   },

diff --git a/components/vc-dialog/DialogWrap.jsx b/components/vc-dialog/DialogWrap.jsx
@@ -5,6 +5,7 @@ import { getStyle, getClass } from '../_util/props-util';
 const IDialogPropTypes = getDialogPropTypes();
 let openCount = 0;
 const DialogWrap = {
+  inheritAttrs: false,
   props: {
     ...IDialogPropTypes,
     visible: IDialogPropTypes.visible.def(false),