fix(types): allow any custom options for defineComponent, fix #579 (#584

)
vuejs · Nov 2, 2020 · 7cdf1e5 · 7cdf1e5 · bbugh · Nov 2, 2020
1 parent 2d6de26
commit 7cdf1e5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/component/componentOptions.ts b/src/component/componentOptions.ts
@@ -45,6 +45,10 @@ interface ComponentOptionsBase<
     Vue2ComponentOptions<Vue, D, M, C, Props>,
     'data' | 'computed' | 'method' | 'setup' | 'props'
   > {
+  // allow any custom options
+  [key: string]: any
+
+  // rewrite options api types
   data?: (this: Props & Vue, vm: Props) => D
   computed?: C
   methods?: M

diff --git a/test/types/defineComponent.spec.ts b/test/types/defineComponent.spec.ts
@@ -1,10 +1,4 @@
-import {
-  defineComponent,
-  h,
-  ref,
-  SetupContext,
-  PropType,
-} from '../../src'
+import { defineComponent, h, ref, SetupContext, PropType } from '../../src'
 import Router from 'vue-router'
 
 const Vue = require('vue/dist/vue.common.js')
@@ -167,6 +161,14 @@ describe('defineComponent', () => {
     expect.assertions(2)
   })
 
+  it('should any custom options', () => {
+    const App = defineComponent({
+      foo: 'foo',
+      bar: 'bar',
+    })
+    new Vue(App)
+  })
+
   it('infer the required prop', () => {
     const App = defineComponent({
       props: {