fix(reactive): fix issue when using reactive array in the template
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Sep 18, 2020
antfu
reviewed
Sep 18, 2020
| b.list[0].count.value === 0 // true | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| <details> | ||
| <summary> | ||
| ✅ <b>Should</b> always use <code>ref</code> in a <code>reactive</code> when working with <code>Array</code> |
There was a problem hiding this comment.
Ah, do you mean "If you need to use ref in Array, wrap it with reactive"?
There was a problem hiding this comment.
This is the message we had before :D
https://github.com/vuejs/composition-api/tree/556292d0d60220722fac2cd401b1ba061d6b05ba#ref-unwrap
There was a problem hiding this comment.
Not a native English speaker, which statement makes more sense to you? We can improve other statements along the way.
antfu
reviewed
Oct 1, 2020
antfu
reviewed
Oct 1, 2020
antfu
reviewed
Oct 1, 2020
| expect(JSON.parse(vm.$el.textContent)).toStrictEqual([{ value: 1 }]) | ||
| }) | ||
|
|
||
| // TODO make this pass |
There was a problem hiding this comment.
Planned to support it in this PR or another?
antfu
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #524
Readded the recommendation of using
ref([])instead ofreactive([]), becausereactive([])doesn't work well withcomputedatm