-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reactive): fix issue when using reactive array
in the template
#532
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d4f562a
fix(reactive): fix issue when using reactive `array` in the template
pikax 87b4507
chore: rollback readme
pikax 6f56442
Update src/mixin.ts
antfu 605e105
Update src/mixin.ts
antfu 412cd14
Merge branch 'master' into fix/reactive_array_on_template
pikax d54d0c7
Merge branch 'master' into fix/reactive_array_on_template
pikax 1ae4939
chore: fix imports
pikax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -896,6 +896,110 @@ describe('setup', () => { | |
expect(vm.$el.textContent).toBe('2') | ||
}) | ||
|
||
// #524 | ||
it('should work with reactive arrays.', async () => { | ||
const opts = { | ||
template: `<div>{{items.length}}</div>`, | ||
setup() { | ||
const items = reactive([]) | ||
|
||
setTimeout(() => { | ||
items.push(2) | ||
}, 1) | ||
|
||
return { | ||
items, | ||
} | ||
}, | ||
} | ||
const Constructor = Vue.extend(opts).extend({}) | ||
|
||
const vm = new Vue(Constructor).$mount() | ||
expect(vm.$el.textContent).toBe('0') | ||
await sleep(10) | ||
await nextTick() | ||
expect(vm.$el.textContent).toBe('1') | ||
}) | ||
|
||
it('should work with reactive array nested', async () => { | ||
const opts = { | ||
template: `<div>{{a.items.length}}</div>`, | ||
setup() { | ||
const items = reactive([]) | ||
|
||
setTimeout(() => { | ||
items.push(2) | ||
}, 1) | ||
|
||
return { | ||
a: { | ||
items, | ||
}, | ||
} | ||
}, | ||
} | ||
const Constructor = Vue.extend(opts).extend({}) | ||
|
||
const vm = new Vue(Constructor).$mount() | ||
expect(vm.$el.textContent).toBe('0') | ||
await sleep(10) | ||
await nextTick() | ||
expect(vm.$el.textContent).toBe('1') | ||
}) | ||
|
||
it('should not unwrap reactive array nested', async () => { | ||
const opts = { | ||
template: `<div>{{a.items}}</div>`, | ||
setup() { | ||
const items = reactive([]) | ||
|
||
setTimeout(() => { | ||
items.push(ref(1)) | ||
}, 1) | ||
|
||
return { | ||
a: { | ||
items, | ||
}, | ||
} | ||
}, | ||
} | ||
const Constructor = Vue.extend(opts).extend({}) | ||
|
||
const vm = new Vue(Constructor).$mount() | ||
expect(vm.$el.textContent).toBe('[]') | ||
await sleep(10) | ||
await nextTick() | ||
expect(JSON.parse(vm.$el.textContent)).toStrictEqual([{ value: 1 }]) | ||
}) | ||
|
||
// TODO make this pass | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Planned to support it in this PR or another? |
||
// it('should work with computed', async ()=>{ | ||
// const opts = { | ||
// template: `<div>{{len}}</div>`, | ||
// setup() { | ||
// const array = reactive([]); | ||
// const len = computed(()=> array.length); | ||
|
||
// setTimeout(() => { | ||
// array.push(2) | ||
// }, 1) | ||
|
||
// return { | ||
// len | ||
// } | ||
// }, | ||
// } | ||
// const Constructor = Vue.extend(opts).extend({}) | ||
|
||
// const vm = new Vue(Constructor).$mount() | ||
// expect(vm.$el.textContent).toBe('0') | ||
// await sleep(10) | ||
// await nextTick() | ||
// expect(vm.$el.textContent).toBe('1') | ||
// }) | ||
|
||
|
||
// #448 | ||
it('should not cause infinite loop', async () => { | ||
const A = defineComponent({ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, do you mean "If you need to use ref in Array, wrap it with
reactive
"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the message we had before :D
https://github.com/vuejs/composition-api/tree/556292d0d60220722fac2cd401b1ba061d6b05ba#ref-unwrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a native English speaker, which statement makes more sense to you? We can improve other statements along the way.