Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reactive object with 'value' property #167

Closed
wants to merge 1 commit into from
Closed

Support reactive object with 'value' property #167

wants to merge 1 commit into from

Conversation

dvic
Copy link

@dvic dvic commented Oct 24, 2019 •
edited
Loading

@dvic
Copy link
Author

dvic commented Nov 21, 2019

@liximomo thoughts?

@renyamizuno
Copy link

So cool! 🆒

but this pattern fail. (may be)

image

@dvic
Copy link
Author

dvic commented Nov 29, 2019

@renyamizuno interesting, maybe this could be solved using the new recursive types support in TS, but I'll have to check.

@LinusBorg
Copy link
Member

I think this will be solved more elegantly with #199

If you agree I'll close his.

@dvic
Copy link
Author

dvic commented May 29, 2020

agreed, this can be closed

@dvic dvic closed this May 29, 2020
@dvic dvic deleted the reactive-value-fix branch May 29, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type for reactive was wrong Type infer error if interface has "value" property
3 participants
@dvic @renyamizuno @LinusBorg