Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix(types): ensure correct oldValue typing based on lazy option #274

Closed
wants to merge 1 commit into from
Closed

Conversation

colinscz
Copy link

@colinscz colinscz commented Mar 5, 2020

  • adjust test cases and add new ones
  • correct vm.$watch calls, which are currently not matching anymore
No overload matches this call.
  Overload 1 of 2, '(expOrFn: string, callback: (this: CombinedVueInstance<Vue, object, object, object, Record<never, any>>, n: any, o: any) => void, options?: WatchOptions | undefined): () => void', gave the following error.
    Das Argument vom Typ "() => void" kann dem Parameter vom Typ "string" nicht zugewiesen werden.
  Overload 2 of 2, '(expOrFn: (this: CombinedVueInstance<Vue, object, object, object, Record<never, any>>) => void, callback: (this: CombinedVueInstance<Vue, object, object, object, Record<...>>, n: void, o: void) => void, options?: WatchOptions | undefined): () => void', gave the following error.
  • corrected typos
  • adjust method headers and add typings

#253

@LinusBorg
Copy link
Member

This will have a merge conflict with #275 which should be merged next to ensure we keep up with the RFC.

Would you be up to adjust your PR once #275 has been merged?

@colinscz
Copy link
Author

colinscz commented Mar 9, 2020

@LinusBorg sure I can do that after #275 has been merged.

@colinscz
Copy link
Author

@LinusBorg I just saw that I took the wrong branch (dev) for this pull request, I will close this one and open a new one, which is based of master. That PR will include the discussed changes from #275 and my work.

@colinscz colinscz closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants