Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Remove Function type from PropType type #352

Merged
merged 1 commit into from Jun 7, 2020
Merged

types: Remove Function type from PropType type #352

merged 1 commit into from Jun 7, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Jun 7, 2020

fix #291

Gets the correct type for the prop

Similar to #301

interface A {
  a: String
}

defineComponent({
  props: {
    a: Object as PropType<A>
  },
  setup(props){
    props.a 
  }
})

antfu
antfu approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@antfu antfu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's quick! Confirmed working.

@antfu
Copy link
Member

antfu commented Jun 7, 2020

I have double-checked the code and I think it's alright, let's ship it with v0.6.0!

@antfu antfu merged commit 387f484 into vuejs:master Jun 7, 2020
antfu added a commit that referenced this pull request Jun 7, 2020
@antfu
chore: update CHANGELOG for #352
7358f0d
@antfu antfu mentioned this pull request Jun 7, 2020
Closed
sapphi-red added a commit to sapphi-red/composition-api that referenced this pull request Jun 11, 2020
@sapphi-red
reapply vuejs#352 and fix test
d001ad9
@sapphi-red sapphi-red mentioned this pull request Jun 11, 2020
Merged
antfu pushed a commit that referenced this pull request Jun 12, 2020
@sapphi-red
reapply #352 and fix test (#371)
13ac1ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript: 'Function' type of PropType introduced in 0.5.0 is annoying when using Vetur
2 participants
@pikax @antfu