Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add failing test of isReactive #795

Closed
wants to merge 1 commit into from
Closed

Conversation

posva
Copy link
Member

@posva posva commented Aug 19, 2021

I only added the failing test because I don't know where this should be fixed. I imagine something related to defineAccessControl() but I couldn't figure it out yet so feel free to to add commits to the PRs or create a new one

Note the same code works in client and on Vue 3

@posva posva added the bug Something isn't working label Aug 19, 2021
@webfansplz
Copy link
Member

webfansplz commented Aug 19, 2021

@posva

Reason: #537
Solution: #546

i have mentioned PR to fix it. @antfu

@antfu antfu closed this in #796 Aug 21, 2021
@posva posva deleted the bug/ssr-isReactive branch September 1, 2021 08:04
@posva posva restored the bug/ssr-isReactive branch October 1, 2021 10:19
@posva
Copy link
Member Author

posva commented Oct 1, 2021

This test is failing again and creates the error at vuejs/pinia#648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants