Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: obj[key] have already triggered the getter #914

Merged
merged 1 commit into from Mar 29, 2022
Merged

refactor: obj[key] have already triggered the getter #914

merged 1 commit into from Mar 29, 2022

Conversation

wavesheep
Copy link
Contributor

let val = obj[key] have already triggerd the getter; So const value = getter ? getter.call(obj) : val is redundant

@antfu antfu changed the title improve: remove redundant code. obj[key] have already triggered the g… refactor: obj[key] have already triggered the getter Mar 29, 2022
@antfu antfu merged commit 000ffe4 into vuejs:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OXXXRA OXXXRA OXXXRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wavesheep @OXXXRA @antfu