Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

access a ref nested in reactive cause "Maximum call stack size exceeded" #11696

Open
edison1105 opened this issue Aug 23, 2024 · 3 comments · May be fixed by #11694
Open

access a ref nested in reactive cause "Maximum call stack size exceeded" #11696

edison1105 opened this issue Aug 23, 2024 · 3 comments · May be fixed by #11694
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: reactivity

Comments

@edison1105
Copy link
Member

edison1105 commented Aug 23, 2024 •
edited

Vue version

3.5

Link to minimal reproduction

https://play.vuejs.org/#eNp9kcFOwzAMhl8lymWdNjrQ4DJ1kwDtAAdAwDES6jq3y0iTKHHKpKnvjtNuYwe0m+3/c/Lb3vN7a9MmAJ/xzBdOWmQeMNiF0LK2xiHbMwd5gbKBMUXlmEFZQoGsZaUzNRtQ80DowmiPLGfzE50QnNwMh0IL3bckyZDNF2wvNGORNwpSZaokT5tcBSCy7ehDPhoJnU16U2SHEoTaqhyBMsayVUA0erGR2eQQRv6M4WOOnj4qZZVuvdE0Y/e34IWprVTgXi1KMiL4rHcVtVwp8/Pc1dAFGB/rxQaK73/qW7+LNcHfHHhwDQh+0jB3FWAvLz9eYEfxSazNOiiiL4jvQEsK0WOPPQS9JttnXOf2qbuU1NWnX+4QtD8OFY1Gsu14welWjxdG/7M7TW+7PjoJbfGrARffpAVO07v0+moFmKdT3v4CP+C+wQ==

Steps to reproduce

open the link

What is expected?

No error

What is actually happening?

An error occurred "Maximum call stack size exceeded"

System Info

System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1
    Memory: 122.11 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.16.0 - /usr/local/bin/node
    Yarn: 1.22.22 - /usr/local/bin/yarn
    npm: 10.8.1 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
    bun: 1.0.0 - /usr/local/bin/bun
  Browsers:
    Chrome: 127.0.6533.122
    Safari: 17.5

Any additional comments?

It works fine in v3.4

The problem was discovered while reviewing the PRs below:
#6359
#6376

The reason is that dep is processed as reactive data
image
@edison1105 edison1105 added 🐞 bug Something isn't working scope: reactivity labels Aug 23, 2024
@edison1105 edison1105 linked a pull request Aug 23, 2024 that will close this issue
Open
@riskysciolism
Copy link

riskysciolism commented Aug 23, 2024 •
edited

Seems to be a major issue as it freezes our application when using primevue datatables with row grouping.

@edison1105 edison1105 added the ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. label Aug 23, 2024
@riskysciolism
Copy link

It does not work fine in v3.4.
It does work fine in v3.3.

@edison1105
Copy link
Member Author

@riskysciolism
It sounds like your problem is not the same as this one. this one only happens in v3.5.
Please try to create a new issue with a minimal runnable reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(reactivity): handle a ref directly nested in reactive edison1105/vuejs-core
2 participants
@edison1105 @riskysciolism