-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. (fix: #6358) #6376
Merged
yyx990803
merged 6 commits into
vuejs:main
from
lidlanca:fix-ref-wrapped-in-reactive-should-not-track-ref-internal-value
Aug 29, 2024
Merged
fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. (fix: #6358) #6376
yyx990803
merged 6 commits into
vuejs:main
from
lidlanca:fix-ref-wrapped-in-reactive-should-not-track-ref-internal-value
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidlanca
changed the title
fix(reactivity): ref directly wrapped in proxy, should not track internal _value access.
fix(reactivity): ref directly wrapped in proxy, should not track internal _value access. (fix: #6358)
Jul 28, 2022
For anyone looking to review this, I've posted a comparison with #6359 (comment) on that PR. |
Size ReportBundles
Usages
|
❌ Deploy Preview for vue-sfc-playground failed.
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
edison1105
added
the
🛑 on hold
This PR can't be merged until other work is finished
label
Aug 28, 2024
The fix is no longer needed in 3.5 after 313e4bf, but the test case is merged as it is useful to prevent future regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It need to wait for #11696 to be fixed
may fix : #6358
playground+patched
playground non patched v3.2.37