Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings are broken on <tr> inside <slot> #766

Closed
jods4 opened this issue Feb 23, 2020 · 1 comment
Closed

Bindings are broken on <tr> inside <slot> #766

jods4 opened this issue Feb 23, 2020 · 1 comment

Comments

@jods4
Copy link
Contributor

jods4 commented Feb 23, 2020

Version

3.0.0-alpha.6

Reproduction link

https://codesandbox.io/s/v-model-decomposed-camel-case-d9blu

Steps to reproduce

Open the repro, click on toggle.

What is expected?

All v-if should hide.

What is actually happening?

v-if on <tr> inside <slot> stays visible.

This seems like a bad bug but there's no apparent logic. v-if does work on a div inside the slot, for example.
ysj16 added a commit to ysj16/vue-next that referenced this issue Feb 24, 2020
@ysj16
fix(renderSlot): set slot render as a STABLE_FRAGMENT (fix vuejs#766)
c21ef45
ysj16 added a commit to ysj16/vue-next that referenced this issue Feb 25, 2020
@ysj16
fix(transformElement): sub-component‘s direct child should openBlock (f…
10456fa 
…ix vuejs#766)
ysj16 added a commit to ysj16/vue-next that referenced this issue Feb 25, 2020
@ysj16
Revert "fix(transformElement): sub-component‘s direct child should op…
ebf30fe 
…enBlock (fix vuejs#766)"

This reverts commit 10456fa.
@yyx990803 yyx990803 mentioned this issue Feb 25, 2020
Merged
@jods4
Copy link
Contributor Author

jods4 commented Feb 25, 2020

@yyx990803 Would love an alpha.7 soon if you can, this bug has high impact and breaks many bindings for me.

@jods4 jods4 mentioned this issue Feb 25, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jods4