Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): Pass oldValue to triggerRefValue to satisfy interface DebuggerEventExtraInfo #8210

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

Azurewarth0920
Copy link
Contributor

@Azurewarth0920 Azurewarth0920 commented May 2, 2023

fix: vuejs/pinia#2061

The DebuggerEventExtraInfo triggered by a computed ref doesn't have the field oldValue.

For consistency (consistent with reactive), added oldValue to debuggerEventExtraInfo.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried applying these changes locally to the latest main.

The conflicts proved much simpler to resolve than I was expecting and it appears these changes still work.

I was worried about the impact on production bundle size, so I checked that too. It seems to add 2 bytes, for the extra parameter on triggerRefValue. Everything else is removed.

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. easy to merge labels Jun 2, 2024
@yyx990803 yyx990803 merged commit 3b0a56a into vuejs:main Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. easy to merge ready to merge The PR is ready to be merged.
Projects
Development

Successfully merging this pull request may close these issues.

DevTools: Undefined value for oldValue in mutation event using Setup Stores
4 participants