Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): stringify values on v-text #2432

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

posva
Copy link
Member

@posva posva commented Oct 19, 2020

Close #2430

TODO:

  • fix existing tests
  • When do we need to pass the loc parameter? It seems to be always optional but it changes what is highlighted on the template explorer

@github-actions
Copy link

github-actions bot commented Oct 19, 2020

Size report

Path Size
vue.global.prod.js 39.97 KB (-0.04% 🔽)
runtime-dom.global.prod.js 26.3 KB (0%)
size-check.global.prod.js 15.8 KB (0%)

exp || createSimpleExpression('', true)
createSimpleExpression(`textContent`, true),
exp
? createCallExpression(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right thing to call or should I use a different create*Expression()?

@yyx990803 yyx990803 merged commit 314ab2c into master Oct 19, 2020
@yyx990803 yyx990803 deleted the fix/2430/v-text-like-interpolate branch October 19, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-text no longer outputs JSON.stringified objects
2 participants