Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): v-show leaves is not working with transition #2764

Closed
wants to merge 2 commits into from
Closed

fix(runtime-dom): v-show leaves is not working with transition #2764

wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 8, 2020 •
edited
Loading

close #2757
the bug is caused by: 3cd30c5

@edison1105 edison1105 requested a review from posva December 8, 2020 13:17
@LinusBorg
Copy link
Member

@posva Think this is ready?

@LinusBorg LinusBorg added scope: transition ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Feb 13, 2021
@HcySunYang
Copy link
Member

This make #2583 happen again.

@edison1105
Copy link
Member Author

edison1105 commented Feb 15, 2021 •
edited
Loading

This make #2583 happen again.

I dont think so,I tested it and it works fine.

@HcySunYang
Copy link
Member

HcySunYang commented Feb 15, 2021 •
edited
Loading

You can try this in your local with your PR https://codepen.io/hcysunyang/pen/YzpZyQW

I found a better way #3230

@edison1105
Copy link
Member Author

You can try this in your local with your PR codepen.io/hcysunyang/pen/YzpZyQW

I found a better way #3230

got the point.

@edison1105 edison1105 closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva Awaiting requested review from posva

Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition effect of v-show leaves is not working in some cases
4 participants
@edison1105 @LinusBorg @HcySunYang @posva