fix(v-show): v-show takes higher priority than style attribute #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyundukov
suggested changes
Feb 16, 2021
|
Another way to deal with the problem is that we parse the string type style into an object, but I think this has two shortcomings:
|
posva
reviewed
Feb 19, 2021
| // so we always keep the current `display` value regardless of the `style` value, | ||
| // thus handing over control to `v-show`. | ||
| if ('_vod' in el) { | ||
| style.display = current |
There was a problem hiding this comment.
Do you think this will trigger a reflow? https://csstriggers.com/display
There was a problem hiding this comment.
I think this is ok, because v-show always sets the display property no matter what it is here 🤔
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2757
This PR is also re-fixed #2583, even though this commit can fix issue #2583, but it causes issue #2757.