fix(compiler-ssr): should generate the correct hoists expression #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
added
the
🔨 p3-minor-bug
HcySunYang
added
❗ p4-important
|
Turns out we should not be hoisting when targeting SSR at all. See 3ef1fcc |
|
I've updated my test case to Vue 3.1.0-beta4 (https://github.com/lukewarlow/vue-server-render-bug) but I still experience the issue with incorrect srcset in the SSR output. Is there some change I need to make to my SSR code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3536
Looking at the test snapshot in this PR, you can see that it generated duplicate hoists expressions:
For the current implementation, this is expected. And I think @edison1105 's PR(#3215) can improve it