fix: fix transition-group processing of whitespace nodes #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been waiting for three weeks, could someone look at this please? It blocks the Vue 3 migration for the Wikimedia Foundation (Wikipedia and related websites) |
|
This doesn't look like the right fix as Transition direct children should be elements (so classes can be added) 🤔 Are you sure this fixed #4622 ? A previously failing test would also help to move things forward. |
edison1105
reviewed
Oct 25, 2023
| @@ -470,7 +471,8 @@ export function getTransitionRawChildren( | |||
| ) | |||
| } | |||
| // comment placeholders should be skipped, e.g. v-if | |||
| else if (keepComment || child.type !== Comment) { | |||
| // #4621, #4622, #4637 also skip text nodes | |||
| else if ((keepComment || child.type !== Comment) && child.type !== Text) { | |||
There was a problem hiding this comment.
This is not a correct fix and will even cause the following code not to render foo correctly.
<transition-group>
foo
</transition-group>We can't filter its raw children, we should filter the rendered children
|
I think this may have been fixed in 3.4.22 by #9421. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4621
fixes #4622