build(deps-dev): bump typescript to 4.7.4 #6215
Conversation
| @@ -30,7 +30,7 @@ export class ComputedRefImpl<T> { | |||
| public readonly effect: ReactiveEffect<T> | |||
|
|
|||
| public readonly __v_isRef = true | |||
| public readonly [ReactiveFlags.IS_READONLY]: boolean | |||
| public readonly [ReactiveFlags.IS_READONLY]: boolean = false | |||
There was a problem hiding this comment.
Seems typescript 4.7.x is not able to recognise this variable being set on the constructor, just in case I've initialised here
❌ Deploy Preview for vuejs-coverage failed.
|
| // @ts-expect-error types are not compatible | ||
| extend(finalCompilerOptions.compatConfig, Component.compatConfig) |
There was a problem hiding this comment.
I've checked the types and they are different, we could possible update the finalCompilerOptions.compatConfig to also contain the Component.compatConfig, but I wasn't sure about it
| @@ -128,14 +128,14 @@ function testRender(type: string, render: typeof renderToString) { | |||
| await render( | |||
| createApp( | |||
| defineComponent({ | |||
| extends: { | |||
| extends: defineComponent({ | |||
There was a problem hiding this comment.
Typescript has hard type inferring component options, I believe we should always enforce the usage of defineComponent in this occasions
| (await Promise.all(context.__teleportBuffers[key])) as SSRBuffer | ||
| await Promise.all([context.__teleportBuffers[key]]) |
There was a problem hiding this comment.
Can I have a review on this change please, from the type this change makes sense, but from the previous code it seems the __teleportBuffers is Record<string, Promise<buffer>[]> if that's the case we must update the typing instead of casting
❌ Deploy Preview for vuejs-coverage failed.
|
No description provided.