Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): export MarkRaw type #6380

merged 4 commits into from Nov 8, 2022


Copy link

@sxzz sxzz commented Jul 29, 2022

closes #7048


src/main.ts:3:14 - error TS4023: Exported variable 'foo' has or is using name 'RawSymbol' from external module "/path/vue-issue-markRaw/node_modules/.pnpm/@vue+reactivity@3.2.37/node_modules/@vue/reactivity/dist/reactivity" but cannot be named.

3 export const foo = markRaw({ key: 'value' })

@sxzz sxzz changed the title fix(reactivity): markRaw typing fix(reactivity): markRaw typing Jul 29, 2022
@sxzz sxzz changed the title fix(reactivity): markRaw typing fix(reactivity): export markRaw typing Sep 3, 2022
antfu approved these changes Oct 3, 2022
@antfu antfu changed the title fix(reactivity): export markRaw typing fix(reactivity): export MarkRaw type Oct 3, 2022
Copy link

posva commented Nov 7, 2022

There seem to be more types that are being reported as missing by api-extractor.

I wonder if some of these should be exported but prefixed with an _ and marked as @internal so we don't expose types that aren't meant to be used in userland like this one.

@yyx990803 yyx990803 merged commit e9172db into vuejs:main Nov 8, 2022
9 checks passed
@sxzz sxzz deleted the fix/markRaw branch November 8, 2022 10:11
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

error TS4058 caused by RawSymbol
4 participants