Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): dynamic import type annotation #6457

Merged
merged 1 commit into from Nov 8, 2022
Merged

fix(compiler-sfc): dynamic import type annotation #6457

merged 1 commit into from Nov 8, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 12, 2022

  • the correct type is Statement[], instead of Statement.
  • comment of type annotation is useless for dts file. So I change it to dynamic import.

@yyx990803 yyx990803 merged commit 97aadd8 into vuejs:main Nov 8, 2022
@yyx990803
Copy link
Member

Previously the any casting was a hack to avoid the generated dts relying on @babel/types, but now it looks pointless since compiler-core also relies on @babel/types, and @babel/types is included as a dep of @babel/parser anyway.

@sxzz sxzz deleted the fix/ast-type branch November 8, 2022 10:12
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@sxzz
types: use actual type for script block ASTs (vuejs#6457)
35ab1c3
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@sxzz @zhangzhonghe
types: use actual type for script block ASTs (vuejs#6457)
7cdd2c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sxzz @yyx990803 @antfu