Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydration): improve comment node hydration #9532

Closed
wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Nov 2, 2023

close #9531
The root cause is that the node is a <!--[-->.

<template>
  <div><span>foo</span><!--[--></div>
</template>

see
BTW, support hydrate left square bracket comment node

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit e45c020
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/654352221776ee000848d1e9

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit e45c020
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/654352226efdcf0008f3635b

Copy link

github-actions bot commented Nov 2, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB (-7 B) 32.9 kB (+5 B) 29.7 kB (-9 B)
vue.global.prod.js 132 kB (-7 B) 49.6 kB (+7 B) 44.6 kB (+47 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB (-7 B) 20.2 kB (+7 B) 18.4 kB (+19 B)
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@edison1105 edison1105 changed the title fix(hydration): improve template node check fix(hydration): improve comment node hydration Nov 2, 2023
@yyx990803
Copy link
Member

We haven't seen a real reproduction from the original reports, I'm not sure if this is caused by a real left bracket comment since that would be very unlikely in user code.

@yyx990803
Copy link
Member

See #9531 (comment)

I think the case you raised is still valid (although really an edge case)

@edison1105 edison1105 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt3 Entry.js tagName.toLowerCase() Error
2 participants