Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint run-on-save VSCode settings #466

Closed
yoshi-pi opened this issue Mar 14, 2024 · 3 comments
Closed

Add ESLint run-on-save VSCode settings #466

yoshi-pi opened this issue Mar 14, 2024 · 3 comments

Comments

@yoshi-pi
Copy link
Contributor

As of #442, settings.json is now added when picking Prettier. How about adding the following setting when picking ESLint as well, so that linting is done on save?

{
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": "explicit"
  }
}

Related Issue
#302
@cexbrayat
Copy link
Member

Hi @yoshi-pi

Yes, I think this would be a good idea.
Would you like to open a PR for this? We would gladly review and merge it.

yoshi-pi added a commit to yoshi-pi/create-vue that referenced this issue Mar 14, 2024
@yoshi-pi
feat: add vscode config for ESLint vuejs#466
8a1012f
@yoshi-pi yoshi-pi mentioned this issue Mar 14, 2024
Merged
@yoshi-pi
Copy link
Contributor Author

yoshi-pi commented Mar 14, 2024 •
edited

@cexbrayat I have opened a PR!

@sodatea
Copy link
Member

sodatea commented Mar 19, 2024

Released

@sodatea sodatea closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cexbrayat @sodatea @yoshi-pi