Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode config for ESLint #467

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

yoshi-pi
Copy link
Contributor

Description

If the user picks ESLint, then suggest the ESLint .vscode extension, and add the settings.

settings.json

{
  "editor.codeActionsOnSave": {
    "source.fixAll": "explicit"
  }
}

extensions.json

{
  "recommendations": ["dbaeumer.vscode-eslint"]
}

Related Issue

#466

Notes for Reviewers

  • Created template/config/eslint dedicated to ESLint's static settings, including .vscode/extensions.json and .vscode/settings.json.
  • Removed the existing code for adding the ESLint extension.
  • Added code to merge Prettier settings into settings.json instead of overwriting them.
  • Enabled generation of ESLint and Prettier snapshots.

Copy link
Contributor

@Yordan-Ramchev Yordan-Ramchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for scripts/snapshot.mjs

This is going to make a lot of new snapshots

I think cexbrayat will provide better feedback for scripts/snapshot.mjs (for reference, #460 (comment)).

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the snapshot generation, LGTM, thanks for the PR.

]
const featureFlagsDenylist = [
['eslint', 'eslint-with-prettier'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to this file should be removed, as this is going to generate a lot of new snapshots (that's why they aren't generated at the moment).

Copy link
Contributor Author

@yoshi-pi yoshi-pi Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved eslint and eslint-with-prettier as separate features based on #460 (comment).

@@ -120,6 +120,7 @@ async function init() {
argv.nightwatch ??
argv.playwright ??
argv.eslint ??
argv['eslint-with-prettier'] ??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@sodatea sodatea merged commit bebba95 into vuejs:main Mar 19, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants