Update REGEX in no-side-effects-in-computed-properties (#308)

vuejs · Dec 31, 2017 · 45104ad · 45104ad
1 parent b434ff9
commit 45104ad
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/rules/no-side-effects-in-computed-properties.js b/lib/rules/no-side-effects-in-computed-properties.js
@@ -27,7 +27,7 @@ function create (context) {
       // this.xxx.func()
       'CallExpression' (node) {
         const code = context.getSourceCode().getText(node)
-        const MUTATION_REGEX = /(this.)((?!(concat|slice|map|filter)\().)*((push|pop|shift|unshift|reverse|splice|sort|copyWithin|fill)\()/g
+        const MUTATION_REGEX = /(this.)((?!(concat|slice|map|filter)\().)[^\)]*((push|pop|shift|unshift|reverse|splice|sort|copyWithin|fill)\()/g
 
         if (MUTATION_REGEX.test(code)) {
           forbiddenNodes.push(node)

diff --git a/tests/lib/rules/no-side-effects-in-computed-properties.js b/tests/lib/rules/no-side-effects-in-computed-properties.js
@@ -73,6 +73,14 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
                 test: 'example'
               }
             }
+          },
+          test9() {
+            return Object.keys(this.a).sort()
+          },
+          test10: {
+            get() {
+              return Object.keys(this.a).sort()
+            }
           }
         }
       })`,
@@ -144,6 +152,9 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
             this.something[index] = thing[index]
             return this.something
           },
+          test6() {
+            return this.something.keys.sort()
+          }
         }
       })`,
       parserOptions,
@@ -165,6 +176,9 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
       }, {
         line: 21,
         message: 'Unexpected side effect in "test5" computed property.'
+      }, {
+        line: 25,
+        message: 'Unexpected side effect in "test6" computed property.'
       }]
     },
     {