Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #306] Update REGEX in no-side-effects-in-computed-properties #308

Merged
merged 1 commit into from
Dec 31, 2017
Merged

[Fixes #306] Update REGEX in no-side-effects-in-computed-properties #308

merged 1 commit into from
Dec 31, 2017

Conversation

michalsnik
Copy link
Member

This PR updates REGEX to check whether this.xxx haven't been used as an argument in an expression. If yes - don't throw a warning.

mysticatea
mysticatea approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@michalsnik michalsnik merged commit 45104ad into master Dec 31, 2017
@michalsnik michalsnik deleted the fix-no-side-effects-in-cp branch December 31, 2017 11:42
@michalsnik michalsnik mentioned this pull request Dec 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@chrisvfritz chrisvfritz Awaiting requested review from chrisvfritz

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalsnik @mysticatea