Fix: ensure that executeOnVueComponent is called after object instead…

… of before. (fixes #173)(#175)
vuejs · Sep 7, 2017 · 827aaf9 · 827aaf9
1 parent 1c827b3
commit 827aaf9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -457,7 +457,7 @@ module.exports = {
     }
 
     return {
-      ObjectExpression (node) {
+      'ObjectExpression:exit' (node) {
         if (!componentComments.some(el => el.loc.end.line === node.loc.start.line - 1) || isDuplicateNode(node)) return
         cb(node)
       },

diff --git a/tests/lib/rules/return-in-computed-property.js b/tests/lib/rules/return-in-computed-property.js
@@ -237,6 +237,25 @@ ruleTester.run('return-in-computed-property', rule, {
         message: 'Expected to return a value in "foo" computed property.',
         line: 4
       }]
+    },
+    {
+      filename: 'test.js',
+      code: `
+        // @vue/component
+        export default {
+          computed: {
+              my_FALSE_test() {
+                  let aa = 2;
+                  this.my_id = aa;
+              }
+          }
+        }
+      `,
+      parserOptions,
+      errors: [{
+        message: 'Expected to return a value in "my_FALSE_test" computed property.',
+        line: 5
+      }]
     }
   ]
 })