Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Ensure that executeOnVueComponent is called after other queries. #175

Merged
merged 1 commit into from
Sep 7, 2017
Merged

[patch] Ensure that executeOnVueComponent is called after other queries. #175

merged 1 commit into from
Sep 7, 2017

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Sep 4, 2017

fixes #173

@armano2 armano2 changed the title Ensure that executeOnVueComponent is called after object instead of before. [patch] Ensure that executeOnVueComponent is called after other queries. Sep 4, 2017
mysticatea
mysticatea approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@mysticatea mysticatea merged commit 827aaf9 into vuejs:master Sep 7, 2017
@armano2 armano2 deleted the 173-return-in-computed-property branch September 7, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return-in-computed-property error not triggered
3 participants
@armano2 @mysticatea @aladdin-add