fix(no-useless-v-bind): remove spaces around string in fixes (#2408)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
vuejs · Feb 23, 2024 · 8a781f0 · 8a781f0
1 parent 0fb68b3
commit 8a781f0
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/rules/no-useless-v-bind.js b/lib/rules/no-useless-v-bind.js
@@ -132,14 +132,16 @@ module.exports = {
           let attrValue
           if (quoteChar === '"') {
             attrValue = strValue.replace(DOUBLE_QUOTES_RE, '&quot;')
+            attrValue = quoteChar + attrValue + quoteChar
           } else if (quoteChar === "'") {
             attrValue = strValue.replace(SINGLE_QUOTES_RE, '&apos;')
+            attrValue = quoteChar + attrValue + quoteChar
           } else {
             attrValue = strValue
               .replace(DOUBLE_QUOTES_RE, '&quot;')
               .replace(SINGLE_QUOTES_RE, '&apos;')
           }
-          yield fixer.replaceText(expression, attrValue)
+          yield fixer.replaceText(value, attrValue)
         }
       })
     }

diff --git a/tests/lib/rules/no-useless-v-bind.js b/tests/lib/rules/no-useless-v-bind.js
@@ -136,6 +136,34 @@ tester.run('no-useless-v-bind', rule, {
         'Unexpected `v-bind` with a string literal value.',
         'Unexpected `v-bind` with a string literal value.'
       ]
+    },
+    {
+      code: `
+      <template>
+        <div :id="    'foo'    " />
+        <div :id='    "foo"    ' />
+        <div :id="   \`foo\`   " />
+        <div :id='   \`foo\`   ' />
+        <div :id="' \\'foo\\' '" />
+        <div :id='" \\"foo\\" "' />
+      </template>`,
+      output: `
+      <template>
+        <div id="foo" />
+        <div id='foo' />
+        <div id="foo" />
+        <div id='foo' />
+        <div id=" 'foo' " />
+        <div id=' "foo" ' />
+      </template>`,
+      errors: [
+        'Unexpected `v-bind` with a string literal value.',
+        'Unexpected `v-bind` with a string literal value.',
+        'Unexpected `v-bind` with a string literal value.',
+        'Unexpected `v-bind` with a string literal value.',
+        'Unexpected `v-bind` with a string literal value.',
+        'Unexpected `v-bind` with a string literal value.'
+      ]
     }
   ]
 })