Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added no-deprecated-vue-extend rule. #2085

Closed

Conversation

madogiwa0124
Copy link
Contributor

Vue.extend is removed in Vue.js 3.0.0+.

Vue.extend Removed
https://v3-migration.vuejs.org/breaking-changes/global-api.html#vue-extend-removed

This rule checks for disallow using deprecated Vue.extend.

`Vue.extend` is removed in Vue.js 3.0.0+.

> Vue.extend Removed
> https://v3-migration.vuejs.org/breaking-changes/global-api.html#vue-extend-removed

This rule checks for disallow using deprecated `Vue.extend`.
@ota-meshi
Copy link
Member

Thank you for opening the PR.

I'm not sure people should check it. I think we no longer use the Vue identifier when building applications with Vue3. I think it can be checked by just checking the default exports.

     "no-restricted-imports": [
       "error",
       {
         "paths": [
           {
             "name": "vue",
             "importNames": ["default"]
           },
         ],
       },
     ],

@madogiwa0124
Copy link
Contributor Author

@ota-meshi

Indeed. I had not thought of that ! That seems like a good way to do it 👍🏻

Thanks for the review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants