feat: implement require-explicit-slots

[mussinbenarbia]

This is an attempt at solving #2294

I would like to hear your opinion on the handling of slots declared twice. As you can see from the implementation, I'm reporting this as well but I'm not sure if such a thing should be responsibility of this rule.

What do you think?

Also, I did not implement a fixer for now as we do not know how the slot function is typed. I think this is good enough for now but any opinions?

Thank you.

[mussinbenarbia]

Looks like the tests are failing 🤔 They all pass locally, let me see if there is some version mismatch somewhere.

EDIT: Seems to be due to node version. It fails on 14 but succeeds on 16. I'm thinking:

• Vue 3 minimum required version is Node 16
• This rule should only be applicable in Vue 3, due to defineSlots only working in script setup.

Maybe this is ok? I'm not sure what the protocol is for these cases so I'll wait for the reviewers' input 🙇

[FloEdelmann]

We plan to drop support for Node v14 and v16 in eslint-plugin-vue v10 (see #2166), so new rules intended to be merged before that major version should be compatible with Node v14 as well. But we can also mark this PR as a breaking change and only release it with or after v10.

[mussinbenarbia]

@FloEdelmann I think this makes sense to introduce in v10 then since consumers of it wouldn't be on node 14 anyway due to the reasons mentioned above 🙏

[mussinbenarbia]

@ota-meshi @FloEdelmann I made some changes to the implementation based on the comments. Could you please take another look when you get the chance? 🙏

[mussinbenarbia]

@ota-meshi I addressed the comments. I'm not sure if I understood the comment about the docs correctly. I'll make the change if it's still wrong

[ota-meshi]

LGTM! Thank you!

[FloEdelmann]

Thanks for implementing the feedback! This looks good to me now 🙂