Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement require-explicit-slots #2325

Merged
merged 7 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions docs/rules/require-explicit-slots.md
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/require-explicit-slots
description: require slots to be explicitly defined with defineSlots
---

# vue/require-explicit-slots

> require slots to be explicitly defined

- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>

## :book: Rule Details

This rule enforces all slots used in the template to be defined once either in the `script setup` block with the [`defineSlots`](https://vuejs.org/api/sfc-script-setup.html) macro, or with the [`slots property`](https://vuejs.org/api/options-rendering.html#slots) in the Options API.

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<!-- ✓ GOOD -->
<template>
<div>
<slot />
</div>
</template>
<script setup lang="ts">
defineSlots<{
default(props: { msg: string }): any
}>()
</script>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<!-- ✓ GOOD -->
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
<template>
<div>
<slot name="foo" />
</div>
</template>
<script setup lang="ts">
defineSlots<{
foo(props: { msg: string }): any
}>()
</script>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<!-- ✓ GOOD -->
<template>
<div>
<slot name="foo" />
</div>
</template>
<script lang="ts">
import { SlotsType } from 'vue'
defineComponent({
slots: Object as SlotsType<{
foo: { msg: string }
}>
})
</script>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<!-- ✗ BAD -->
<template>
<div>
<slot />
</div>
</template>
<script setup lang="ts"></script>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/require-explicit-slots': ['error']}">

```vue
<!-- ✗ BAD -->
<template>
<div>
<slot name="foo" />
</div>
</template>
<script setup lang="ts">
defineSlots<{
bar(props: { msg: string }): any
}>()
</script>
```

</eslint-code-block>
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved

## :wrench: Options

Nothing.
128 changes: 128 additions & 0 deletions lib/rules/require-explicit-slots.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
/**
* @author Mussin Benarbia
* See LICENSE file in root directory for full license.
*/
'use strict'

const utils = require('../utils')

/**
* @typedef {import('@typescript-eslint/types').TSESTree.TypeNode} TypeNode
*/

module.exports = {
meta: {
type: 'problem',
docs: {
description: 'require slots to be explicitly defined',
categories: undefined,
url: 'https://eslint.vuejs.org/rules/require-explicit-slots.html'
},
fixable: null,
schema: [],
messages: {
requireExplicitSlots: 'Slots must be explicitly defined.',
alreadyDefinedSlot: 'Slot {{slotName}} is already defined.'
}
},
/** @param {RuleContext} context */
create(context) {
const sourceCode = context.getSourceCode()
const documentFragment =
sourceCode.parserServices.getDocumentFragment &&
sourceCode.parserServices.getDocumentFragment()
if (!documentFragment) {
return {}
}
const scripts = documentFragment.children.filter(
(element) => utils.isVElement(element) && element.name === 'script'
)
if (scripts.every((script) => !utils.hasAttribute(script, 'lang', 'ts'))) {
return {}
}
const slotsDefined = new Set()
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved

return utils.compositingVisitors(
utils.defineScriptSetupVisitor(context, {
onDefineSlotsEnter(node) {
const typeArguments =
'typeArguments' in node ? node.typeArguments : node.typeParameters
const param = /** @type {TypeNode|undefined} */ (
typeArguments?.params[0]
)
if (!param) return

if (param.type === 'TSTypeLiteral') {
for (const memberNode of param.members) {
const slotName = memberNode.key.name
if (slotsDefined.has(slotName)) {
context.report({
node: memberNode,
messageId: 'alreadyDefinedSlot',
data: {
slotName
}
})
} else {
slotsDefined.add(slotName)
}
}
}
}
}),
utils.executeOnVue(context, (obj) => {
const slotsProperty = utils.findProperty(obj, 'slots')
if (!slotsProperty) return

const slotsTypeHelper =
slotsProperty.value.typeAnnotation?.typeName.name === 'SlotsType' &&
slotsProperty.value.typeAnnotation
if (!slotsTypeHelper) return

const typeArguments =
'typeArguments' in slotsTypeHelper
? slotsTypeHelper.typeArguments
: slotsTypeHelper.typeParameters
const param = /** @type {TypeNode|undefined} */ (
typeArguments?.params[0]
)
if (!param) return

if (param.type === 'TSTypeLiteral') {
for (const memberNode of param.members) {
const slotName = memberNode.key.name
if (slotsDefined.has(slotName)) {
context.report({
node: memberNode,
messageId: 'alreadyDefinedSlot',
data: {
slotName
}
})
} else {
slotsDefined.add(slotName)
}
}
}
}),
utils.defineTemplateBodyVisitor(context, {
"VElement[name='slot']"(node) {
let slotName = 'default'

const slotNameAttr = utils.getAttribute(node, 'name')

if (slotNameAttr) {
slotName = slotNameAttr.value.value
}

if (!slotsDefined.has(slotName)) {
context.report({
node,
messageId: 'requireExplicitSlots'
})
}
}
})
)
}
}
Loading
Loading