refactor: eliminate need for error wrapper class #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
requested review from
pikax,
a team,
afontcu,
dobromir-hristov and
JessicaSachs
and removed request for
a team
pikax
approved these changes
Apr 30, 2020
afontcu
approved these changes
Apr 30, 2020
dobromir-hristov
approved these changes
Apr 30, 2020
| return createWrapper(null, result[0]) | ||
| } | ||
|
|
||
| return createWrapperError('VueWrapper') |
There was a problem hiding this comment.
I see we lost the selector on the error wrapper. What was it used for?
There was a problem hiding this comment.
Turns out it wasn't used for anything - maybe it was previously, but in the current master is it not used. So I just deleted it.
This was referenced May 1, 2020
Closed
|
I'm late to the party, but I think this API is much more sound 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly simplify the concept of
ErrorWrapperand eliminate the need for theWrapperAPIinterfaces (since they are not implemented by more than one class).It's everyone favorite kind of PR - one that has more deletions than insertions!
#91 and #92