-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change type for unableAutoUnmount #1966
Conversation
I think this change for `enableAutoUnmount` type makes it easier to understand.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think you can update the types at the same time 👍
docs/api/index.md
Outdated
@@ -1886,7 +1886,7 @@ function shallowMount(Component, options?: MountingOptions): VueWrapper | |||
**Signature:** | |||
|
|||
```ts | |||
enableAutoUnmount(hook: Function)); | |||
enableAutoUnmount(hook: (callback: Function) => void)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even hook: (callback: () => void) => void
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update types, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be coherent, maybe change the type here in the docs as well to be the same as the TS types?
I think this change for
enableAutoUnmount
type makes it easier to understand.If ok, i can change types in this PR too )